Skip to content

Commit

Permalink
Clear console errors (proptype violations) from CLI output (jaegertra…
Browse files Browse the repository at this point in the history
…cing#615)

These tests, due to missing required props, were leaving console.error messages in the test run CLI output. It doesn't effect the tests, it doesn't cause any false positives or negatives, but it could be seen as a distraction seeing red output fly across the screen in an otherwise passing test.

Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
  • Loading branch information
tklever authored and vvvprabhakar committed Jul 4, 2021
1 parent 2e8e308 commit b4a3c45
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ const DATE_FORMAT = 'YYYY-MM-DD';
const TIME_FORMAT = 'HH:mm';
const defaultProps = {
dataCenters: ['dc1'],
handleSubmit: () => {},
searchMaxLookback: {
label: '2 Days',
value: '2d',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import transformTraceData from '../../../model/transform-trace-data';
const trace = transformTraceData(traceGenerator.trace({}));

it('<ResultItem /> should render base case correctly', () => {
const wrapper = shallow(<ResultItem trace={trace} durationPercent={50} />);
const wrapper = shallow(<ResultItem trace={trace} durationPercent={50} linkTo="" />);
const numberOfSpanText = wrapper
.find(`[data-test="${markers.NUM_SPANS}"]`)
.first()
Expand All @@ -36,7 +36,7 @@ it('<ResultItem /> should render base case correctly', () => {
});

it('<ResultItem /> should not render any ServiceTags when there are no services', () => {
const wrapper = shallow(<ResultItem trace={{ ...trace, services: [] }} durationPercent={50} />);
const wrapper = shallow(<ResultItem trace={{ ...trace, services: [] }} durationPercent={50} linkTo="" />);
const serviceTags = wrapper.find(`[data-test="${markers.SERVICE_TAGS}"]`).find(Tag);
expect(serviceTags).toHaveLength(0);
});

0 comments on commit b4a3c45

Please sign in to comment.