Add vyos_bgp_address_family resource module. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GomathiselviS <gomathiselvi@gmail.com>
|
recheck |
|
recheck |
NilashishC
reviewed
Mar 15, 2021
| @@ -174,7 +174,7 @@ def __init__(self, **kwargs): | |||
| }, | |||
| "disable_connected_check": {"type": "bool"}, | |||
| "address": {"type": "str"}, | |||
| "password": {"type": "str"}, | |||
| "password": {"type": "str", "no_log": True}, | |||
There was a problem hiding this comment.
We should have a discussion regarding this. Setting no_log: True on keys, would break a significant feature of resource modules - round trip.
NilashishC
reviewed
Mar 15, 2021
| @@ -76,7 +76,7 @@ def __init__(self, **kwargs): | |||
| "type": "dict", | |||
| "options": { | |||
| "key_id": {"type": "int"}, | |||
| "key": {"type": "str"}, | |||
| "key": {"type": "str", "no_log": True}, | |||
There was a problem hiding this comment.
Same as above. In fact, for older modules, this might be a breaking change for existing users.
|
recheck |
rohitthakur2590
approved these changes
Mar 25, 2021
|
recheck |
3 similar comments
|
recheck |
|
recheck |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Depends-On: #140
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION