Support configuring area interfaces for OSPFv3 #217
Conversation
Signed-off-by: GomathiselviS <gomathiselvi@gmail.com>
|
The py35 test is failing with: https://dashboard.zuul.ansible.com/t/ansible/build/c9dbbfc72cc6415782966ad7d7bfb49a |
|
Can you Depends-On: ansible/ansible-zuul-jobs#1184 ? |
|
recheck |
|
Ok this does not work. Can you try ansible/ansible-zuul-jobs#1185 instead? |
| @@ -45,6 +45,12 @@ def __init__(self, **kwargs): | |||
| "area_id": {"type": "str"}, | |||
| "export_list": {"type": "str"}, | |||
| "import_list": {"type": "str"}, | |||
| "interface": { | |||
There was a problem hiding this comment.
If this is a new key, the alias is not required? The key can just be interfaces.
There was a problem hiding this comment.
This module is developed in a way that the key name is used to form the cli command. Changing it to interfaces leads to a lot of existing code/key name changes. I am planning to take it up as a separate PR, in which I want to work on changing all the key names, into plural forms, whose values are of type list.
There was a problem hiding this comment.
@GomathiselviS Does it have interface in the facts or the plural one?
There was a problem hiding this comment.
It is interface and so is range and other list elements.
| @@ -61,6 +61,15 @@ | |||
| import_list: | |||
| description: Name of import-list. | |||
| type: str | |||
| interface: | |||
|
recheck |
1 similar comment
|
recheck |
dmbaturin
requested review from
sever-sever
and removed request for
rohitthakur2590
|
The PR has conflicts and no activity in years — shall we close it? |
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
Depends-On: ansible/ansible-zuul-jobs#1184
SUMMARY
Fixes #176
ISSUE TYPE
COMPONENT NAME
vyos_ospfv3.py
ADDITIONAL INFORMATION