Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: assert descriptions in Crowdfund finalize() and participate() #3064

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

nfwsncked
Copy link
Contributor

What I did

Changed "deadline has passed" to "deadline is already overdue" in participate assert description
Changed "deadline not met (yet)" to "deadline is already overdue" in finalize assert description
Changed "the goal has not been reached" to "goal has not been reached" in finalize assert description

How I did it

It was fast and easy, just some typos or not specific descriptions

How to verify it

https://raw.githubusercontent.com/vyperlang/vyper/master/examples/crowdfund.vy
https://raw.githubusercontent.com/nfwsncked/vyper/master/examples/crowdfund.vy

Commit message

improvement: assert descriptions in Crowdfund.finalize() and Crowdfund.p…

Description for the changelog

Better assertion descriptions in Crowdfund example contract

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@nfwsncked nfwsncked marked this pull request as ready for review August 11, 2022 17:27
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #3064 (5b4ae55) into master (5d10ea0) will increase coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #3064      +/-   ##
==========================================
+ Coverage   89.50%   89.54%   +0.03%     
==========================================
  Files          80       80              
  Lines       11342    11342              
  Branches     2553     2553              
==========================================
+ Hits        10152    10156       +4     
+ Misses        797      793       -4     
  Partials      393      393              

see 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

examples/crowdfund.vy Outdated Show resolved Hide resolved
examples/crowdfund.vy Outdated Show resolved Hide resolved
charles-cooper and others added 2 commits November 7, 2023 14:50
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
@charles-cooper charles-cooper enabled auto-merge (squash) November 7, 2023 22:53
@charles-cooper charles-cooper merged commit a87fb8c into vyperlang:master Nov 7, 2023
83 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants