Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support interface as constant value #3411

Closed
wants to merge 14 commits into from

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented May 15, 2023

What I did

Fix #3407

How I did it

add annotation to constant, public VariableDecl nodes

How to verify it

See tests.

Commit message

fix: support interface as constant and default value

Description for the changelog

Support interface as constant and default value

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #3411 (f928861) into master (97ff017) will decrease coverage by 17.60%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master    #3411       +/-   ##
===========================================
- Coverage   88.96%   71.36%   -17.60%     
===========================================
  Files          86       86               
  Lines       10765    10767        +2     
  Branches     2445     2445               
===========================================
- Hits         9577     7684     -1893     
- Misses        786     2465     +1679     
- Partials      402      618      +216     
Impacted Files Coverage Δ
vyper/semantics/analysis/annotation.py 78.83% <ø> (-10.59%) ⬇️
vyper/semantics/analysis/module.py 65.19% <100.00%> (-21.44%) ⬇️

... and 54 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper changed the title fix: support interface as constant and default value fix: support interface as constant value May 15, 2023
@charles-cooper charles-cooper marked this pull request as ready for review May 15, 2023 14:35
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, will write commit message and merge in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't have an interface as a constant
3 participants