Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix test for slice #3633

Merged
merged 11 commits into from
Nov 2, 2023
Merged

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Sep 30, 2023

What I did

Fix failing fuzzing test for slice.

How I did it

Make the test contract for each bytesdata location more specific.

How to verify it

See tests.

Commit message

chore: fix test for `slice``

Description for the changelog

Fix test for slice.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2023

Codecov Report

Merging #3633 (da64003) into master (c913b2d) will decrease coverage by 1.31%.
Report is 12 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #3633      +/-   ##
==========================================
- Coverage   89.01%   87.70%   -1.31%     
==========================================
  Files          86       85       -1     
  Lines       11460    11364      -96     
  Branches     2606     2585      -21     
==========================================
- Hits        10201     9967     -234     
- Misses        836      952     +116     
- Partials      423      445      +22     

see 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tserg tserg changed the title fix: derivation of return type for slice chore: fix test for slice Oct 4, 2023
tests/parser/functions/test_slice.py Dismissed Show dismissed Hide dismissed
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. will merge in a bit

@charles-cooper charles-cooper merged commit 9ce56e7 into vyperlang:master Nov 2, 2023
82 of 83 checks passed
@tserg tserg deleted the fix/slice_return_typ branch November 2, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants