Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update resources section #3656

Merged
merged 5 commits into from
Nov 7, 2023
Merged

docs: update resources section #3656

merged 5 commits into from
Nov 7, 2023

Conversation

pcaversaccio
Copy link
Collaborator

@pcaversaccio pcaversaccio commented Oct 22, 2023

What I did

I made the following changes in the resources.rst file:

How I did it

N/A.

How to verify it

N/A

Commit message

docs: update resources section

Description for the changelog

docs: update resources section

Cute Animal Picture

image

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2023

Codecov Report

Merging #3656 (8175ada) into master (ed0b1e0) will decrease coverage by 0.44%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #3656      +/-   ##
==========================================
- Coverage   89.14%   88.70%   -0.44%     
==========================================
  Files          85       85              
  Lines       11364    11364              
  Branches     2585     2585              
==========================================
- Hits        10131    10081      -50     
- Misses        822      864      +42     
- Partials      411      419       +8     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider moving the old link to the bottom

@pcaversaccio
Copy link
Collaborator Author

Maybe consider moving the old link to the bottom

Yup, makes sense indeed. Addressed via 8175ada.

@pcaversaccio
Copy link
Collaborator Author

any objections @charles-cooper or can we get this merged?

@charles-cooper
Copy link
Member

seems fine. should we add in a link to titanoboa at some point?

@pcaversaccio
Copy link
Collaborator Author

seems fine. should we add in a link to titanoboa at some point?

Sure, done via https://github.com/pcaversaccio/vyper/commit/6e8ba244edc7194a5a101f58a717908e08e8d931.

@charles-cooper charles-cooper merged commit 4f76614 into vyperlang:master Nov 7, 2023
82 of 83 checks passed
@pcaversaccio pcaversaccio deleted the docs branch November 7, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants