feat: replace enum with flag keyword
#3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertoCentonze
changed the title
enum with flag keyword
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -23,7 +23,7 @@ | |||
| ) | |||
| from vyper.semantics.types.shortcuts import BYTES32_T, INT256_T, UINT256_T | |||
| from vyper.semantics.types.subscriptable import SArrayT | |||
| from vyper.semantics.types.user import EnumT | |||
| from vyper.semantics.types.user import FlagT | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
| @@ -248,13 +248,13 @@ | |||
| # comparisons, e.g. `x < y` | |||
|
|
|||
| # TODO fixme circular import | |||
| from vyper.semantics.types.user import EnumT | |||
| from vyper.semantics.types.user import FlagT | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3697 +/- ##
==========================================
- Coverage 83.98% 83.95% -0.04%
==========================================
Files 92 92
Lines 13046 13065 +19
Branches 2928 2934 +6
==========================================
+ Hits 10957 10969 +12
- Misses 1657 1662 +5
- Partials 432 434 +2 ☔ View full report in Codecov by Sentry. |
charles-cooper
pushed a commit
to charles-cooper/vyper
that referenced
this pull request
Dec 27, 2023
per title, replace `enum` with `flag` as it more closely models https://docs.python.org/3/library/enum.html#enum.IntFlag than regular enums. allow `enum` for now (for backwards compatibility) but convert to `flag` internally and issue a warning
DanielSchiavini
added a commit
to DanielSchiavini/vyper-plugin
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Replacing the
enumkeyword withflagto the language as per #3642. A deprecation warning is displayed when usingenum.How I did it
New grammar was added for
flagwhile keeping the old one forenum. In the codebase all functions/classes that previously hadEnumin their name now useFlag.get_nodenow has a condition that checks whetherenumis being used, if it's the case it is internally replaced with flag and a warning is printed.How to verify it
Pre-existing tests for enums were adapted to test for flag
Commit message
feat: replace
enumkeyword withflagDescription for the changelog
The
enumkeyboard has been replaced byflag.enumwill be deprecated in the future.Cute Animal Picture