chore: update lint dependencies #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSchiavini
commented
Dec 20, 2023
fubuloubu
approved these changes
Dec 20, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| function_to_test=lambda: erc20_caller.transfer(w3.eth.accounts[1], -1), | ||
| exception=ValidationError, | ||
| ) | ||
| with assert_tx_failed(ValidationError): |
There was a problem hiding this comment.
this is kind of an interesting use of assert_tx_failed because it exposes a naming issue with assert_tx_failed -- assert_tx_failed doesn't actually necessarily check for transaction failure, it could test any exception (and just anchors the state)
tests/functional/codegen/calling_convention/test_external_contract_calls.py
Outdated
Show resolved
Hide resolved
tests/functional/codegen/calling_convention/test_external_contract_calls.py
Outdated
Show resolved
Hide resolved
tests/functional/codegen/calling_convention/test_return_tuple.py
Outdated
Show resolved
Hide resolved
tests/functional/codegen/calling_convention/test_return_tuple.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3704 +/- ##
==========================================
- Coverage 83.99% 83.94% -0.05%
==========================================
Files 92 92
Lines 13056 13056
Branches 2932 2932
==========================================
- Hits 10966 10960 -6
- Misses 1658 1663 +5
- Partials 432 433 +1 ☔ View full report in Codecov by Sentry. |
DanielSchiavini
force-pushed
the
lint-dependencies
branch
from
0abe8cc
to
0920eb6
Compare
charles-cooper
approved these changes
Dec 21, 2023
charles-cooper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Update lint dependencies.
I have been experiencing some F821 issues when running flake8 with
matchstatements. This seems to have been fixed in pyflakes, so it would be great to update the linting dependencies and be able to use morematchstatements.How I did it
How to verify it
Commit message
Update lint dependencies
Description for the changelog
n/a
Cute Animal Picture