Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reimplement IRnode.__deepcopy__ #3761

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Feb 7, 2024

this results in a 16% improvement in compile time

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

10% compile-time improvement
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e20885e) 84.78% compared to head (36ce195) 84.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3761   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files          92       92           
  Lines       13122    13129    +7     
  Branches     2933     2934    +1     
=======================================
+ Hits        11125    11132    +7     
  Misses       1534     1534           
  Partials      463      463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit 4ecd26b into vyperlang:master Feb 7, 2024
84 checks passed
@charles-cooper charles-cooper deleted the perf/irnode-deepcopy branch February 7, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants