Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deduplicate test files #3773

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Feb 12, 2024

What I did

There were some duplication with test_return_struct.py / test_return_tuple.py with test_struct_return.py / test_tuple_return.py in tests/functional/codegen/calling_convention. This PR merges the tests into the former, with some struct unit tests going into a new tests/functional/codegen/types/test_structs.py file.

How I did it

How to verify it

Commit message

chore: deduplicate test files.

This PR merges the cross-contract tests in `test_return_struct.py` /
`test_return_tuple.py` with `test_struct_return.py` / `test_tuple_return.py`
in `tests/functional/codegen/calling_convention.py`

The remaining struct unit tests were moved into a new file:
`tests/functional/codegen/types/test_structs.py`.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks good, maybe we should merge test_tuple_return.py, test_struct_return.py, and test_return.py.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37ef8f4) 84.94% compared to head (9d166c1) 84.67%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3773      +/-   ##
==========================================
- Coverage   84.94%   84.67%   -0.28%     
==========================================
  Files          92       92              
  Lines       13594    13594              
  Branches     3060     3060              
==========================================
- Hits        11548    11511      -37     
- Misses       1560     1593      +33     
- Partials      486      490       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was able to recreate the diff with a combination of cat and moving files around, confirmed no tests were changed, just moved around.

@charles-cooper charles-cooper merged commit 1fc819c into vyperlang:master Feb 16, 2024
84 checks passed
@tserg tserg deleted the test/deduplicate branch February 17, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants