chore: improve codegen test coverage report #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go through coverage report of vyper/codegen, fix up bunch of little issues with `pragma: nocover`, branch coverage, delete some apparently dead code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3824 +/- ##
==========================================
+ Coverage 85.19% 86.07% +0.88%
==========================================
Files 92 92
Lines 13916 13821 -95
Branches 3118 3052 -66
==========================================
+ Hits 11856 11897 +41
+ Misses 1565 1486 -79
+ Partials 495 438 -57 ☔ View full report in Codecov by Sentry. |
charles-cooper
changed the title
charles-cooper
changed the title
charles-cooper
changed the title
fubuloubu
reviewed
Mar 4, 2024
fubuloubu
approved these changes
Mar 4, 2024
charles-cooper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
go through coverage report of vyper/codegen, fix up bunch of little issues with
pragma: nocover, branch coverage, delete some apparently dead code.How I did it
How to verify it
check coverage report
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture