Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[tool]: remove vyper-serve from setup.py #3936

Merged

Conversation

MoigeMatino
Copy link
Contributor

@MoigeMatino MoigeMatino commented Apr 10, 2024

What I did

  • Removed vyper-serve from setup.py

How I did it

  • Removed its reference from entry_points in setup.py

How to verify it

  • N/A

Commit message

remove reference to the vyper-serve entry point; it no longer exists as
of 98f502bae

Description for the changelog

resolves #3935

Cute Animal Picture

Cute hamster

@charles-cooper charles-cooper changed the title chore: remove vyper-serve from setup.py chore[tool]: remove vyper-serve from setup.py Apr 10, 2024
@charles-cooper charles-cooper changed the title chore[tool]: remove vyper-serve from setup.py chore[tool]: remove vyper-serve from setup.py Apr 10, 2024
@MoigeMatino MoigeMatino changed the title chore[tool]: remove vyper-serve from setup.py chore[tool]: remove reference to the vyper-serve entry point Apr 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (b2db399) to head (3791275).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3936      +/-   ##
==========================================
- Coverage   90.78%   90.42%   -0.37%     
==========================================
  Files          95       95              
  Lines       14414    14414              
  Branches     3196     3196              
==========================================
- Hits        13086    13034      -52     
- Misses        920      956      +36     
- Partials      408      424      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper
Copy link
Member

charles-cooper commented Apr 10, 2024

blocked on a slightly stupid validation rule, waiting on #3937

@charles-cooper charles-cooper changed the title chore[tool]: remove reference to the vyper-serve entry point chore[tool]: remove vyper-serve from setup.py Apr 10, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) April 10, 2024 17:31
@charles-cooper charles-cooper changed the title chore[tool]: remove vyper-serve from setup.py chore[tool]: remove vyper-serve from setup.py Apr 10, 2024
@charles-cooper charles-cooper merged commit d33c737 into vyperlang:master Apr 10, 2024
148 of 149 checks passed
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
remove reference to the vyper-serve entry point; it no longer exists as
of 98f502b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vyper-serve is still lingering in setup.py
4 participants