Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[lang]: recursion in uses analysis for nonreentrant functions #3971

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Apr 25, 2024

What I did

How I did it

How to verify it

Commit message

this commit fixes `uses` analysis for nonreentrant functions, which are
called recursively.

a partial fix for this was applied in cb940684a9137, but it missed the
case where a nonreentrant function is deep in the call tree.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (4a0305a) to head (cffa731).

❗ Current head cffa731 differs from pull request most recent head c41ec42. Consider uploading reports for the commit c41ec42 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3971      +/-   ##
==========================================
- Coverage   90.96%   89.74%   -1.23%     
==========================================
  Files         105      103       -2     
  Lines       15241    14908     -333     
  Branches     3357     3305      -52     
==========================================
- Hits        13864    13379     -485     
- Misses        943     1069     +126     
- Partials      434      460      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper added this to the v0.4.0 milestone May 7, 2024
This reverts commit ab06324.

Revert "fix nonreentrant analysis"

This reverts commit 3762d41.
@charles-cooper charles-cooper changed the title [draft] fix[lang]: nonreentrant analysis [draftfix[lang]: recursion in nonreentrant analysis May 7, 2024
@charles-cooper charles-cooper changed the title [draftfix[lang]: recursion in nonreentrant analysis fix[lang]: recursion in nonreentrant analysis May 7, 2024
@charles-cooper charles-cooper marked this pull request as ready for review May 7, 2024 14:17
@Leminkay
Copy link

Leminkay commented May 8, 2024

Lgtm!

@charles-cooper charles-cooper enabled auto-merge (squash) May 9, 2024 22:18
@charles-cooper charles-cooper changed the title fix[lang]: recursion in nonreentrant analysis fix[lang]: recursion in uses analysis for nonreentrant functions May 9, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) May 9, 2024 22:18
@charles-cooper charles-cooper merged commit 4c66c8c into vyperlang:master May 9, 2024
152 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants