Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[codegen]: same symbol jumpdest merge #3982

Merged

Conversation

harkal
Copy link
Collaborator

@harkal harkal commented Apr 30, 2024

What I did

Fixed assembly optimizer case where trying to optimize two consecutive JUMPDESTs with the same symbol results in no code change, while returning of True in changes.

How I did it

Made the optimization step return False as it should.

How to verify it

Through the included tests

Commit message

Updates the assembly optimizer to return `False` when trying to 
optimize two consecutive `JUMPDEST`s with the same symbol. 
It used to return `True` when no change was made.

+ unit tests

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@harkal harkal force-pushed the bugfix/same_symbol_jumpdest_merge branch from f00214b to 66a8704 Compare May 1, 2024 11:39
@harkal harkal force-pushed the bugfix/same_symbol_jumpdest_merge branch from 66a8704 to 802641e Compare May 1, 2024 11:44
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@charles-cooper charles-cooper merged commit 2e6fbe7 into vyperlang:master May 1, 2024
148 checks passed
@charles-cooper charles-cooper deleted the bugfix/same_symbol_jumpdest_merge branch May 1, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants