Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor[test]: change fixture scope in examples #3995

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented May 2, 2024

roughly 5x performance increase per CPU (testing locally tests/functional/examples/ directory: 27s -> 7s)

What I did

How I did it

How to verify it

Commit message

roughly 5x performance increase per CPU in the
`tests/functional/examples/` directory (testing locally: 27s -> 7s)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

roughly 5x performance increase per CPU (testing locally: 27s -> 7s)
@harkal
Copy link
Collaborator

harkal commented May 2, 2024

🚀

DanielSchiavini and others added 4 commits May 3, 2024 14:40
…rmance"

This reverts commit 979bded, reversing
changes made to 4cb94d5.

it introduces failures into the test suite which seem out of scope of
this PR
Copy link
Contributor

@DanielSchiavini DanielSchiavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@charles-cooper charles-cooper marked this pull request as ready for review May 7, 2024 20:00
@charles-cooper charles-cooper merged commit 3af5390 into vyperlang:master May 7, 2024
149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants