feat[venom]: improve unused variable removal pass #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| i -= 2 | ||
| for operand in inst.get_inputs(): | ||
| new_uses = self.dfg.remove_use(operand, inst) | ||
| for use in new_uses: |
There was a problem hiding this comment.
can use self.work_list.addmany(new_uses)
There was a problem hiding this comment.
Even I can’t keep up with all the cool utility functions I write 😅
vyper/venom/analysis/dfg.py
Outdated
| def remove_use(self, op: IRVariable, inst: IRInstruction) -> list[IRInstruction]: | ||
| uses = self._dfg_inputs.get(op, []) | ||
| uses.remove(inst) | ||
| return uses |
There was a problem hiding this comment.
nit: i'd prefer an API which does one thing at a time, so remove_use() just removes the item, and then the caller needs another call to .get_uses()
There was a problem hiding this comment.
It’s a pattern I use regularly, but I have no strong preference about doing it in two steps
Comment on lines
21
to
22
| for _, inst in self.dfg.outputs.items(): | ||
| work_list.add(inst) |
There was a problem hiding this comment.
Suggested change
| for _, inst in self.dfg.outputs.items(): | |
| work_list.add(inst) | |
| uses = self.dfg.outputs.values() | |
| work_list.addmany(uses) |
There was a problem hiding this comment.
i'm ok with either way tbh
charles-cooper
changed the title
charles-cooper
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implemented a better variable elimination pass. This new implementation is efficient and manages to remove all unused variables in one run.
Additionally, this PR adds some extra utility functions to
OrderedSet()How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture