feat[lang]: use keyword arguments for event instantiation #4257
Commits on Sep 23, 2024
-
-
Implement instantiating events with kwargs
Backwards compatible (with deprecation warning) with positional arguments
Commits on Sep 24, 2024
Commits on Sep 25, 2024
-
we don't need to set a parent node for the kw node's value
Commits on Sep 26, 2024
-
-
rather than converting positional arg ASTs to kwarg ASTs, we handle kwargs alongside the existing positional arg logic
Commits on Sep 30, 2024
-
Move code with effects to straight-line code section
Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
-
Move kwarg validation to helper fn
Reduces duplication around EventT and StructT classes
-
fix: missing validation on events
also update expected exception on some struct failures now that we're using a common helper function
Commits on Oct 1, 2024
-
-
Tighten type constraint on validate_kwargs
Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.