Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor[venom]: remove dup_requirements analysis #4262

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Sep 27, 2024

What I did

How I did it

How to verify it

Commit message

this commit updates `next_liveness` to reflect `out_vars` when the
instruction is the last instruction in the basic block.

after this change, membership in `dup_requirements` is the same as
membership in `next_liveness`, so we can remove the `dup_requirements`
analysis.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

it is the same as next_liveness (if next_liveness reflects out_vars
properly)
@charles-cooper charles-cooper changed the title refactor[venom]: remove dup_requirements analysis refactor[venom]: remove dup_requirements analysis Sep 27, 2024
@charles-cooper charles-cooper marked this pull request as ready for review September 27, 2024 14:53
@charles-cooper charles-cooper merged commit e21f3e8 into vyperlang:master Sep 28, 2024
157 checks passed
@charles-cooper charles-cooper deleted the refactor/dup-requirements-cleanup branch September 28, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants