fix[lang]: disallow absolute relative imports #4268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandbubbles
changed the title
vyper/semantics/analysis/module.py
Outdated
| @@ -789,11 +789,7 @@ def _add_import( | |||
| # load an InterfaceT or ModuleInfo from an import. | |||
| # raises FileNotFoundError | |||
| def _load_import(self, node: vy_ast.VyperNode, level: int, module_str: str, alias: str) -> Any: | |||
There was a problem hiding this comment.
i guess we can fuse load_import_helper right?
| # the directory this (currently being analyzed) module is in | ||
| self_search_path = Path(self.ast.resolved_path).parent | ||
|
|
||
| with self.input_bundle.search_path( |
There was a problem hiding this comment.
i think for a relative import, we actually need to override the entire search path. can be a context manager, but something along the lines of
try:
self.input_bundle.search_paths = [self_search_path]
self._load_import_helper(...)
finally:
self.input_bundle.search_paths = original_search_pathsotherwise you can break out of the current directory if the search path falls back to some other path (e.g. like /usr/lib/site-packages/foo/bar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture