Skip to content

Commit

Permalink
GH actions pls
Browse files Browse the repository at this point in the history
  • Loading branch information
vzarytovskii committed Nov 20, 2023
1 parent 45903e0 commit 8624e0b
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
13 changes: 10 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,17 @@ Fixes # (issue, if applicable)
- [ ] Test cases added
- [ ] Performance benchmarks added in case of performance changes
- [ ] Release notes entry updated:
> Please make sure to add an entry with short succint description of the change as well as link to this pull request, if applicable.
> Examples:
> Please make sure to add an entry with short succint description of the change as well as link to this pull request to the respective release notes file, if applicable.
>
> Release notes files:
> - If anything under `src/Compiler` has been changed, please make sure to make an entry in `docs/release-notes/FSharp.Compiler.Service/<version>.md`, where `<version>` is usually "highest" one, e.g. `42.8.200`
> - If language feature was added (i.e. `LanguageFeatures.fsi` was changed), please add it to `docs/releae-notes/Language/preview.md`
> - If a change to `FSharp.Core` was made, please make sure to edit `docs/release-notes/FSharp.Core/<version>.md` where version is "highest" one, e.g. `8.0.200`.
> Examples of release notes entries:
> - Respect line limit in quick info popup - https://github.com/dotnet/fsharp/pull/16208
> - More inlines for Result module - https://github.com/dotnet/fsharp/pull/16106
> - Miscellaneous fixes to parens analysis - https://github.com/dotnet/fsharp/pull/16262
>
>
> **If you believe that release notes are not necessary for this PR, please add `NO_RELEASE_NOTES` label to the pull request.**
2 changes: 2 additions & 0 deletions .github/workflows/check_release_notes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ jobs:
RELEASE_NOTES_NOT_FOUND=""
PULL_REQUEST_FOUND=true
gh repo set-default dotnet/fsharp
_modified_paths=`gh pr view ${PR_NUMBER} --json files --jq '.files.[].path'`
for fields in ${paths[@]}
Expand Down

0 comments on commit 8624e0b

Please sign in to comment.