Fix: #75. Reference representation data, not message body. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdennehy
reviewed
Oct 11, 2019
index.xml
Outdated
| @@ -575,7 +575,7 @@ Note that the use of the `Digest` header field is per | |||
| <xref target="RFC3230">RFC 3230</xref>, <eref | |||
| target="https://tools.ietf.org/html/rfc3230#section-4.3.2">Section 4.3.2</eref> | |||
| and is included merely as a demonstration of how an implementer could include | |||
| information about the body of the message in the signature. | |||
| informations about the representation of the resource in the signature. | |||
There was a problem hiding this comment.
"information" has no plural form, so no "s" on the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes the ambiguity about message body. In HTTP the message body
is subject to Transfer-Encoding and other transformations that might
invalidate a signature.
Digestfor example, is calculated on theinstance(rfc3230) now standardized asrepresentation data(rfc7231).The now deprecated, rfc723x-inconsistent
Content-MD5instead was calculated on thepayload body.