Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair Credential with their Supporting documents #357

Open
BenjaminMoe opened this issue Mar 22, 2022 · 11 comments
Open

Pair Credential with their Supporting documents #357

BenjaminMoe opened this issue Mar 22, 2022 · 11 comments
Assignees
Labels
post-1.0 This is for issues that are important but should not block 1.0 ready-for-pr

Comments

@BenjaminMoe
Copy link
Contributor

Related to #352. Reference images for documents have been included in descriptions.json file. This is a stop-gap for re-organizing the documentation. The reference images for specific document should be moved to their respective yml files in a future PR.

@nissimsan
Copy link
Collaborator

@BenjaminMoe , great that you've moved this conversation to a dedicated issue.

@OR13 , ref the discussion on the initial PR, I understand that we can add pictures on the .yml files. But I don't think we should.

@OR13
Copy link
Collaborator

OR13 commented Mar 24, 2022

@nissimsan do you agree to abide by OAS 3 and treat descriptions as markdown? or are you saying we should profile down from OAS 3 and forbid markdown in descriptions?

@nissimsan
Copy link
Collaborator

@OR13, I would love support for markdown OAS!

But it's a different point I am trying to make. @BenjaminMoe has externalized references to pictures like the one below into a separate file. And I think that's correct; while useful to display such legacy pictures on our main page, I wouldn't want to include them as part of the formal schema.

image

@TallTed
Copy link
Contributor

TallTed commented Mar 25, 2022

The formal schema could include "based on" or "derived from" or "influenced by" or similar links to the scanned paper forms. I wouldn't include the actual images in the formal schema.

@OR13
Copy link
Collaborator

OR13 commented Mar 25, 2022

https://swagger.io/specification/

Throughout the specification description fields are noted as supporting CommonMark markdown formatting. Where OpenAPI tooling renders rich text it MUST support, at a minimum, markdown syntax as described by CommonMark 0.27. Tooling MAY choose to ignore some CommonMark features to address security concerns.

@nissimsan
Copy link
Collaborator

nissimsan commented Mar 28, 2022

I wouldn't include the actual images in the formal schema.

+1

@BenjaminMoe BenjaminMoe changed the title Move contents of descriptions.json into schema description Pair Credential with their Supporting documents Mar 28, 2022
@BenjaminMoe
Copy link
Contributor Author

Changed the title as my updated PR document use the same json work around, in favor of moving supporting docs to their own section. https://github.com/w3c-ccg/traceability-vocab/pull/364/files

@BenjaminMoe
Copy link
Contributor Author

Use openAPI 3.0 specification for markdown fields.

@OR13
Copy link
Collaborator

OR13 commented Oct 25, 2022

I am a +1 for using absolute URLs and markdown.

@BenjaminMoe
Copy link
Contributor Author

BenjaminMoe commented Mar 14, 2023

Needed improvement.

@mkhraisha
Copy link
Collaborator

@BenjaminMoe any updates on this?

@mkhraisha mkhraisha added the post-1.0 This is for issues that are important but should not block 1.0 label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-1.0 This is for issues that are important but should not block 1.0 ready-for-pr
Projects
None yet
Development

No branches or pull requests

6 participants