Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Credentials into their own Section #364

Merged
merged 8 commits into from
Mar 29, 2022
Merged

Conversation

BenjaminMoe
Copy link
Contributor

@BenjaminMoe BenjaminMoe commented Mar 28, 2022

This PR has the following edits to the respec document

  1. Moves the 'Supporting documents' from workflows into their own subsection
  2. Moved vocabulary description for OpenAPI and Terms from script to top of document
  3. Moved Credentials into their own section to appear in the table of contents
  4. Updated the Vocab section so that Vocabulary Term appears in the table of contents

The most sensible location for Supporting Documents is with the Credential.
How to approach this is the topic of this issue: #357

Will be fixed in a future PR once the approach has been agreed upon.

docs/index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@BenjaminMoe BenjaminMoe changed the title Docs/separate credentials Move Credentials into their own Section Mar 28, 2022
@BenjaminMoe BenjaminMoe marked this pull request as ready for review March 28, 2022 14:39
Copy link
Collaborator

@mkhraisha mkhraisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkhraisha mkhraisha merged commit 8a2f412 into main Mar 29, 2022
@mkhraisha mkhraisha deleted the docs/separate-credentials branch March 29, 2022 17:44
@BenjaminMoe
Copy link
Contributor Author

#365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants