update verifiable credential wallet query #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As per our discussion in w3c-ccg#85, bringing credential queries in credential wallet inline with [vp-request-spec](https://w3c-ccg.github.io/vp-request-spec/#format) . - removed `proofPurpose` from Issue & Prove interfaces because according to verifiable credential data model specification - "A proof is typically attached to a verifiable presentation for authentication purposes and to a verifiable credential as a method of assertion."
sudeshrshetty
requested review from
kimdhamilton,
mprorock,
NTonani and
OR13
as code owners
OR13
approved these changes
Apr 15, 2021
|
ping @dmitrizagidulin you asked about this. great work @sudeshrshetty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proofPurposefrom Issue & Prove interfaces because according to verifiable credential data model specification - "A proof is typically attached to a verifiable presentation for authentication purposes and to a verifiable credential as a method of assertion."