Reference Permissions Policy for Cross-Origin iframe Support #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think there's a misconception in the explainer that PP would only be useful for per-page control. It actually supports both iframe and header controls. Assuming that the header feature is not harmful to FedCM, PP is the recommended way of adding new `allow` features, makes it easier for implementers to support and more versatile for web developers to work with.
|
@samuelgoto @dj2 wdyt? :) |
|
Oh, and, assuming this change is accepted I'm happy to update the spec as well. Maybe I should have filed an issue for this instead, apologies :) |
npm1
approved these changes
Mar 16, 2022
| @@ -377,31 +377,24 @@ tokens = await cred.refresh({ | |||
|
|
|||
| The IDP calls for `refresh` have not been flushed out yet. | |||
|
|
|||
| #### iframe Support | |||
| #### Cross-Origin iframe Support | |||
dj2
approved these changes
Mar 16, 2022
|
Looks great to me, thanks for the clarification! Accepting and merging (and yes, would love to accept a PR for the spec too if you can get to it!!)!! |
github-actions bot
added a commit
that referenced
this pull request
Mar 16, 2022
SHA: 33a1bac Reason: push, by @samuelgoto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
johannhof
added a commit
to johannhof/FedCM
that referenced
this pull request
Mar 24, 2022
See rationale here: w3c-fedid#233 (comment)
johannhof
added a commit
to johannhof/FedCM
that referenced
this pull request
Aug 4, 2022
See rationale here: w3c-fedid#233 (comment)
johannhof
added a commit
to johannhof/FedCM
that referenced
this pull request
Aug 4, 2022
See rationale here: w3c-fedid#233 (comment)
johannhof
added a commit
to johannhof/FedCM
that referenced
this pull request
Aug 4, 2022
See rationale here: w3c-fedid#233 (comment)
samuelgoto
pushed a commit
that referenced
this pull request
Aug 16, 2022
* Use Permissions Policy instead of sameOriginWithAncestors See rationale here: #233 (comment) * Update feature name based on feedback
cbiesinger
pushed a commit
to cbiesinger/WebID
that referenced
this pull request
Oct 7, 2022
…id#233) I think there's a misconception in the explainer that PP would only be useful for per-page control. It actually supports both iframe and header controls. Assuming that the header feature is not harmful to FedCM, PP is the recommended way of adding new `allow` features, makes it easier for implementers to support and more versatile for web developers to work with.
cbiesinger
pushed a commit
to cbiesinger/WebID
that referenced
this pull request
Oct 7, 2022
) * Use Permissions Policy instead of sameOriginWithAncestors See rationale here: w3c-fedid#233 (comment) * Update feature name based on feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's a misconception in the explainer that PP would only be useful for per-page control. It actually supports both iframe and header controls. Assuming that the header feature is not harmful to FedCM, PP is the recommended way of adding new
allowfeatures, makes it easier for implementers to support and more versatile for web developers to work with.