Allow multiple IDPs in the provider array #368
Conversation
| [=fetch the accounts list=] algorithm with |manifest| and |provider|. | ||
| To <dfn>potentially create IdentityCredential</dfn>, given a list of {{IdentityProviderConfig}} |providers|: | ||
| 1. Let |accountsList| be an empty list. | ||
| 1. For each |provider| in |providers|: |
There was a problem hiding this comment.
| 1. For each |provider| in |providers|: | |
| 1. In parallel, for each |provider| in |providers|: |
We could/should do these in parallel right?
| algorithm with |provider|. | ||
| 1. If |manifest| is null, return null. | ||
| 1. Let |providerAccountsList| be the result of running the | ||
| [=fetch the accounts list=] algorithm with |manifest| and |provider|. |
There was a problem hiding this comment.
Didn't @bvandersloot-mozilla say that he was worried about enabling fetching multiple identity providers before we factored into the IdP Sign-in Status API (because, IIRC, that would allow trackers to be introduced here in this list and fail deliberately invisibly)?
There was a problem hiding this comment.
Maybe we can add an "Issue" here to note that.
| algorithm with |provider|. | ||
| 1. If |manifest| is null, return null. | ||
| 1. Let |providerAccountsList| be the result of running the | ||
| [=fetch the accounts list=] algorithm with |manifest| and |provider|. |
There was a problem hiding this comment.
Maybe we can add an "Issue" here to note that.
|
Can we try to update this PR to contain the latest proposal for the Multiple IdP API @cbiesinger @npm1 and @tttzach ? A PR may be a useful/concrete way that TAG reviews / Mozilla / Webkit can look at to give guidance on (we already have the explainer, which is pretty good, but a spec PR may make things more concrete). |
|
This is kinda outdated but relevant. Do we plan to update this PR or should we close and later send a separate new PR? |
|
I think we can keep this closed and we can pick it up later, either from this PR or start over |
Preview | Diff