-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow IdPs to continue and finish the request in a popup window #1
Comments
ProposalWe are proposing to extend the ID assertion response to let the IDP specify a field called Once finished, the identity provider will call a new function IDLdictionary IdentityResolveOptions {
USVString accountId;
};
partial interface IdentityProvider
// Allows an IdP to return a token to the RP from the content area,
// as opposed to over HTTP with the id_assertion_endpoint.
static Promise<undefined> resolve(USVString token,
optional IdentityResolveOptions options = {});
}; And the dictionary for the ID assertion response would be extended like this: dictionary IdentityProviderToken {
optional USVString token;
optional USVString continue_on;
}; Example{
// In the id_assertion_endpoint, instead of returning a typical
// "token" response, the IdP decides that it needs the user to
// continue on pop-up window:
"continue_on": "/oauth/authorize?scope=..."
} The popup might then contain code like this: document.getElementById("allow_btn").addEventListener("click", async () => {
let accessToken = await fetch(`/generate_access_token.cgi`);
// Closes the window and resolves the promise (that is still hanging
// in the relying party's renderer) with the value that is passed.
IdentityProvider.resolve(accessToken);
}); The user agent will then close the popup and resolve the promise (returned from navigator.credentials.get) with the provided token. If for some reason the user has changed in the popup (e.g. the IDP offers a “switch user” function or in delegation cases), the resolve call takes an optional second argument allowing something like: IdentityProvider.resolve(token, {accountId: "1234"); If not provided, the user agent will assume the account ID is unchanged from what the user has selected. ConsiderationsBecause this happens after the user has selected an account, it is safe to allow access to unpartitioned cookies in the popup. However, we still do not allow direct communication with the RP – the popup behaves as if We only want to allow popups when we had a user interaction. Therefore, we allow them when the user selected an account in the account chooser, or in button mode (which always requires user activation). But we don’t want to allow the popup for Due to its versatility, this proposal can also be used for cases where no token will be returned, such as for showing custom error messages. We think this is a feature, not a bug. |
Some thoughts:
|
This is intended to be a regular popup where you can redirect as much as you like. Can you remind me whether you needed the resolve call to be possible from a different domain as well? (close is largely unrelated to this proposal) No requirements for user interaction, as you point out. |
It would be cool if the IdP had a HTTP header version of the |
Do the requests shown in a window in response to the "IDP login dialog" flow include the "Sec-Fetch-Dest: webidentity" HTTP header? If not, why? |
That seems reasonable to me. @cbiesinger, any concern? |
I believe the answer is "no". @cbiesinger ack? |
+1 to the HTTP header version of the js call. This could also be considered for the dynamic sign-in flow. After authenticating the user, the IdP could send the successful authn response only with extra headers causing the pop-up window to close, without the need to modify the signing in process any futher. |
For clarity I don't think it would be cool per se. I think it is a prerequisite for being able to fit the FedCM signals to an existing IdP login interaction rather than having to define a new login form response that is a blank HTML with a <script> block. |
They do not. Similar to the IDP login flow, the continuation URL gets shown in a regular browser popup so the destination is not semantically "the FedCM flow", hence we use the regular destination. (if we wanted to use webidentity, that would also prompt the question what we should send for subresources) |
Makes sense to me, we could definitely define an HTTP header for this, similar to how we have an HTTP version of the login status API. |
FWIW the comments @samuelgoto re-posted from our private conversation don't parcularly pertain to continuation flow but rather any window popped up by FedCM. |
@panva so you are suggesting that you would also like an HTTP version of IdentityProvider.close? |
Yes, that's the one my message to @samuelgoto wss actually about. |
Anything I can't do with headers as an IdP is an annoyance because it means i need to add intermediary script only pages in my existing flow. |
My only real problem with this, and why I think w3c-fedid/FedCM#590 is better is because this forces popups to be used, rather than just allowing the developer to choose what to do, e.g., full-page redirect or popup. |
The problem with redirects is that it does not match super well to a JavaScript API, because by definition it can't return anything to the JavaScript because the document is gone. |
Is there a way we can define a version that uses HTTP headers instead of JavaScript? |
As a replacement for IdentityProvider.resolve? Yes, that was also requested elsewhere, we can definitely do that |
Discussed at TPAC 2024 https://github.com/fedidcg/meetings/blob/main/2024/2024-09-24-TPAC-notes.md#continuation-api Proposal advanced to Stage 2 |
* Specify the continuation API Bug: w3c-fedid/custom-requests#1 * swap order * first * rename and in parallel * remove if necessary * failure
(this has been split out of w3c-fedid/FedCM#477 )
FedCM’s account chooser and disclosure dialog only allows asking for permission to share standard claims (e.g. user’s name, email address and profile picture). However, commonly Identity Providers (IdPs) need to ask for additional information before returning the token to the relying party (RP), such as requesting re-authentication, scopes beyond standard claims (e.g. API access), verifying up-to-date contact information, parental controls, etc.
There is currently no mechanism that an IdP can use to use their own words to request their user's permission before returning a token to the RP.
The text was updated successfully, but these errors were encountered: