Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Storage Partitioning #382

Closed
arichiv opened this issue May 31, 2022 · 3 comments · Fixed by #383
Closed

Support Storage Partitioning #382

arichiv opened this issue May 31, 2022 · 3 comments · Fixed by #383
Labels
needs-tests storage buckets Handle this with Storage Buckets instead?

Comments

@arichiv
Copy link
Member

arichiv commented May 31, 2022

Right now IndexedDB is partitioned by the frame's origin, but we should partition third-party iframes independently from first-party frames: https://docs.google.com/document/d/1xd6MXcUhfnZqIe5dt2CTyCn6gEZ7nOezAEWS0W9hwbQ/edit?resourcekey=0-Z5Xn1i5GJ4rit6_93QKIvA

Every time 'origin' is referenced in the spec, we should replace it with a placeholder for origin or double key'd origin depending on how the storage is partitioned.

@inexorabletash
Copy link
Member

#334 is a start on the integration.

@inexorabletash inexorabletash added needs-tests storage buckets Handle this with Storage Buckets instead? labels May 31, 2022
@arichiv
Copy link
Member Author

arichiv commented Jun 1, 2022

@inexorabletash would you object to something more like w3c/ServiceWorker#1630 ? I want to make a limited change just to make it clear the storage key (instead of origin) is the way forward.

@inexorabletash
Copy link
Member

No objection! I think when I started on the patch linked above, Storage Key wasn't exported and the intent was that storage endpoints needed to live in a bottle (or some such - it's been a while) and scoping was completely implicit. If that's changed, or we can do the work more incrementally, I'm down for reviewing PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests storage buckets Handle this with Storage Buckets instead?
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants