Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Storage Partitioning #383

Merged
merged 12 commits into from
Jun 8, 2022
Merged

Support Storage Partitioning #383

merged 12 commits into from
Jun 8, 2022

Conversation

arichiv
Copy link
Member

@arichiv arichiv commented Jun 2, 2022

This PR is more of a find and replace right now, not all the concepts translate perfectly as https://html.spec.whatwg.org/multipage/webappapis.html#environment-settings-objects needs a storage key and https://storage.spec.whatwg.org/#storage-keys needs to define the opaque concept.

Closes #382

The following tasks have been completed:

Implementation commitment:


Preview | Diff

arichiv added 4 commits June 2, 2022 11:32
This PR is more of a find and replace right now, not all the concepts translate perfectly as https://html.spec.whatwg.org/multipage/webappapis.html#environment-settings-objects needs a storage key and https://storage.spec.whatwg.org/#storage-keys needs to define the opaque concept.
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
@inexorabletash
Copy link
Member

FYI that I made an update to #334 which could use more eyeballs, and would simplify/unblock this.

@arichiv arichiv requested a review from inexorabletash June 5, 2022 16:13
@arichiv
Copy link
Member Author

arichiv commented Jun 5, 2022

Could we get this in first? It seems correct as is and #334 has been in-progress for two years.

Copy link
Member

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#334 is probably pretty close now, I just hadn't spent any time on it. Just need to replace "pumpkin" with something. We definitely need #384 - hopefully I can get a reviewer to chime in soon.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Member

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last comments/suggestions, then we can probably merge.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
arichiv and others added 4 commits June 8, 2022 13:13
Co-authored-by: Joshua Bell <inexorabletash@gmail.com>
@arichiv arichiv requested a review from inexorabletash June 8, 2022 17:24
@inexorabletash inexorabletash merged commit 513352e into w3c:main Jun 8, 2022
github-actions bot added a commit that referenced this pull request Jun 8, 2022
SHA: 513352e
Reason: push, by @inexorabletash

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@arichiv arichiv deleted the patch-1 branch June 8, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Storage Partitioning
3 participants