Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dictionary default value #292

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Add dictionary default value #292

merged 2 commits into from
Aug 27, 2019

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Aug 23, 2019

Required after whatwg/webidl#750. (Found from web-platform-tests/wpt#18382)

The following tasks have been completed:

  • Confirmed there are no ReSpec/BikeShed errors or warnings.
  • Modified Web platform tests (link to pull request)

Implementation commitment:


Preview | Diff

Copy link
Member

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! One nitpick to fix before merging.

index.bs Outdated
@@ -2455,7 +2455,7 @@ interface IDBDatabase : EventTarget {
void close();

[NewObject] IDBObjectStore createObjectStore(DOMString name,
optional IDBObjectStoreParameters options);
optional IDBObjectStoreParameters options = {});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the Preview, this causes the rendered IDL in the spec to require scrolling to view.

Please adjust the wrapping here (e.g. move the DOMString name param down and left)

Copy link
Member

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@inexorabletash inexorabletash merged commit 24f51a8 into w3c:master Aug 27, 2019
@saschanaz saschanaz deleted the patch-2 branch August 28, 2019 01:32
inexorabletash pushed a commit that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants