Rename "open a database" algorithm to "open a database connection" #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evanstade WDYT? |
It's more correct, and symmetric with "close a database connection". Resolves #410.
|
@a-sully can you take a peek as well? |
a-sully
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
LGTM % a repeat of the same (optional!) comment I left here: #409 (comment)
I did some rough searching, and didn't turn up direct links except for within issues in the repo. Of course "indexeddb" plus "open a database" turns up a ton of hits, but none that were links to that algorithm. So... same as before, will make the change w/o keeping the old ID, and see if anyone complains. Thanks for being thorough, though! |
github-actions bot
added a commit
that referenced
this pull request
Aug 8, 2023
) SHA: bfd4953 Reason: push, by inexorabletash Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #410
The following tasks have been completed:
Preview | Diff