Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about we move the polyfill out? #433

Closed
marcoscaceres opened this issue Jun 4, 2020 · 8 comments · Fixed by #499
Closed

How about we move the polyfill out? #433

marcoscaceres opened this issue Jun 4, 2020 · 8 comments · Fixed by #499
Assignees
Labels

Comments

@marcoscaceres
Copy link
Member

It might be good to move the polyfill out... then it makes it easier for us to manage spec issues and polyfill issues.

@siusin
Copy link
Contributor

siusin commented Jun 4, 2020

We can create a new repo for the polyfill under w3c if needed. @philipwalton would you be willing to be the maintainer?

@szager-chromium
Copy link
Collaborator

I think it's also worth discussing whether we should just freeze/archive the polyfill code and auto-close the polyfill issues, now that IntersectionObserver is supported natively by all major browsers.

@siusin
Copy link
Contributor

siusin commented Aug 27, 2020

SGTM :)

@marcoscaceres
Copy link
Member Author

@szager-chromium, can we take this up again? i.e., close/freeze all the polyfill stuff?

@miketaylr
Copy link
Member

@marcoscaceres @szager-chromium I'm triaging all the issues currently - I think it makes sense to archive/freeze the polyfill once we go through them all. Some are valid (typo in code), but most appear to be old browser bugs that should be handled by native implementations now. My plan is to close those and we'll see where we're at (perhaps cut one last version).

@marcoscaceres
Copy link
Member Author

Thanks for the update and helping with this, @miketaylr!

@miketaylr
Copy link
Member

I had a chat with @emilio about this, and he agrees that we should just remove it from the repo. @philipwalton - any thoughts of where we should move this? Deleting it entirely without the ability to update npm for an emergency hotfix maybe isn't the best idea. But I'm not sure if anybody really wants to maintain this... maybe we move it to GoogleChromeLabs and archive it?

@philipwalton
Copy link
Member

I'm fine with moving it to GoogleChromeLabs and archiving it. We can work with folks on our OSS team to get the repo created.

@miketaylr miketaylr self-assigned this Jun 15, 2022
miketaylr added a commit to miketaylr/IntersectionObserver that referenced this issue Jul 6, 2022
miketaylr added a commit to miketaylr/IntersectionObserver that referenced this issue Jul 6, 2022
emilio pushed a commit that referenced this issue Jul 6, 2022
github-actions bot added a commit that referenced this issue Jul 6, 2022
SHA: 591d13a
Reason: push, by @emilio

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants