Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit [Exposed] + default dictionary value #382

Closed
wants to merge 1 commit into from
Closed

Add explicit [Exposed] + default dictionary value #382

wants to merge 1 commit into from

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Aug 23, 2019 •
edited by pr-preview bot
Loading

yoavweiss
yoavweiss approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss
Copy link
Contributor

/cc @szager-chromium

@saschanaz
Copy link
Member Author

Fixed by #414

@saschanaz saschanaz closed this Sep 10, 2020
@saschanaz saschanaz deleted the patch-1 branch September 10, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschanaz @yoavweiss