Allow setting thresholds
#485
Conversation
index.bs
Outdated
| readonly attribute DOMString rootMargin; | ||
| readonly attribute FrozenArray<double> thresholds; | ||
| attribute DOMString rootMargin; | ||
| attribute FrozenArray<double> thresholds; |
There was a problem hiding this comment.
I don't think non-readonly FrozenArrays are a thing?
There was a problem hiding this comment.
What should we use here?
There was a problem hiding this comment.
probably sequence<double>? Though not a webIDL expert so...
There was a problem hiding this comment.
ObservableArray<double> would be best, yeah. Attributes cannot be sequence<>s. You can have settable FrozenArray<>s, but the semantics are confusing, thus we invented ObservableArray<>...
There was a problem hiding this comment.
| attribute FrozenArray<double> thresholds; | |
| attribute ObservableArray<double> thresholds; |
There was a problem hiding this comment.
ObservableArrays don't have on-getting/on-setting algorithms though. They need a different setup, "set an indexed value" and "delete an indexed value". See https://webidl.spec.whatwg.org/#idl-observable-array
|
I can edit this branch to only change |
zcorpan
changed the title
thresholds
Co-authored-by: Emilio Cobos Álvarez <emilio@crisal.io>
|
As with modifying rootMargin, we need to specify the effect of modifying thresholds on previousThresholdIndex: |
|
This thread was buried in my inbox and I got to it by doing some cleaning up. Out of curiosity, is there any progress here? @zcorpan Do you plan to continue this? |
|
@domfarolino if there's impl interest I can make a plan. :) |
|
I see. Maybe we can just ping @szager-chromium and @emilio, and I'm not sure for Apple? .... |
Part of #428.
The following tasks have been completed:
Implementation commitment:
Preview | Diff