Fix overflow clipping. #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #504. The overflow property clips to padding edges, so IntersectionObserver should match that clip.
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 18, 2023
This is a spec issue. See the test. The element is completely visible, so the intersection ratio should be 1. Spec issue: w3c/IntersectionObserver#504 Spec PR: w3c/IntersectionObserver#517 Differential Revision: https://phabricator.services.mozilla.com/D191277 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1796268 gecko-commit: 75132d2a2bac7bc70e1dc808f197967750004238 gecko-reviewers: smaug
tcaptan-cr
approved these changes
Oct 18, 2023
cfallin
pushed a commit
to cfallin/gecko-dev
that referenced
this pull request
Oct 18, 2023
…padding. r=smaug This is a spec issue. See the test. The element is completely visible, so the intersection ratio should be 1. Spec issue: w3c/IntersectionObserver#504 Spec PR: w3c/IntersectionObserver#517 Differential Revision: https://phabricator.services.mozilla.com/D191277
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 19, 2023
This is a spec issue. See the test. The element is completely visible, so the intersection ratio should be 1. Spec issue: w3c/IntersectionObserver#504 Spec PR: w3c/IntersectionObserver#517 Differential Revision: https://phabricator.services.mozilla.com/D191277 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1796268 gecko-commit: 75132d2a2bac7bc70e1dc808f197967750004238 gecko-reviewers: smaug
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 20, 2023
…padding. r=smaug This is a spec issue. See the test. The element is completely visible, so the intersection ratio should be 1. Spec issue: w3c/IntersectionObserver#504 Spec PR: w3c/IntersectionObserver#517 Differential Revision: https://phabricator.services.mozilla.com/D191277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504. The overflow property clips to padding edges, so IntersectionObserver should match that clip.
The following tasks have been completed:
Browser bugs:
Preview | Diff