Specify how "terminate" works #1612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
annevk
reviewed
Nov 16, 2021
docs/index.bs
Outdated
| : <dfn>state</dfn> (default "<code>ongoing</code>") | ||
| :: "<code>ongoing</code>" or "<code>terminated</code>". | ||
|
|
||
| : <dfn>preload fetch controller</dfn> (default null) |
There was a problem hiding this comment.
I'm not sure we want to reuse the word preload for this, but I'm also not sure the original controller needs to be installed here. Can it not forward it being aborted?
There was a problem hiding this comment.
It's used to forward being aborted... I can rename but I don't entirely understand the comment
There was a problem hiding this comment.
It's used to forward being aborted... I can rename but I don't entirely understand the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with whatwg/fetch#1329.
When the SW fetch starts, it emits an
onStartcallback with a controllerinstance. That controller instance can be used to terminate the service worker
fetch and it's internal fetches.
Preview | Diff