Do not render zeros in place of omitted content (#852)

By relying on the "truthiness" of Number values to short-circuit boolean expressions, some rendering logic produced the text "0" instead of omitting any markup at all. Replace the expressions whose value could be coerced to booleans with expressions which directly evaluate to "fallback" values that do not produce markup (i.e. `false` or an empty array).
w3c · Dec 5, 2023 · 703b01f · 703b01f
1 parent 7783342
commit 703b01f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/client/components/TestQueueRow/index.jsx b/client/components/TestQueueRow/index.jsx
@@ -569,7 +569,7 @@ const TestQueueRow = ({
                             {isAdmin && renderOpenAsDropdown()}
                             {isAdmin && renderDeleteMenu()}
                             {(!isAdmin &&
-                                currentUserTestPlanRun.testResultsLength && (
+                                currentUserTestPlanRun.testResultsLength > 0 && (
                                     <Button
                                         ref={deleteTesterResultsButtonRef}
                                         variant="danger"

diff --git a/client/components/common/BasicThemedModal/index.jsx b/client/components/common/BasicThemedModal/index.jsx
@@ -101,8 +101,7 @@ const BasicThemedModal = ({
                             {closeLabel}
                         </Button>
                     )}
-                    {actionButtons.length &&
-                        actionButtons.map(({ action, text }) => (
+                    {actionButtons.map(({ action, text }) => (
                             <Button
                                 key={text}
                                 variant={