Temporarily revise the valid combinations of ATs and Browsers for embed.js
#650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alflennik
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Code looks good - I agree that in the future it might be nice to have this data in the resolvers, but actually for the immediate future calculating these values in controller actually seems pretty clean.
I ran it and verified that the data is showing up as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #583.
I've revised the
getAllAtBrowserCombinationsfunction after noticing that there's a case where the function may cause the/embedurl to incorrectly display a AT/Browser pairing asNot Applicablewhen it should sayData Not Yet Availableinstead.I've noted this as a temporary patch as it only applies for this file and having a useable solution to be used elsewhere in the application would be best. It most recently aligns with requirements described in /648.
This is currently being tracked in #625