-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support results being copied even when commands have been added or removed between versions #967
Merged
howard-e
merged 16 commits into
development
from
supportPreservingResultsWithCommandsChanged
Apr 10, 2024
Merged
Support results being copied even when commands have been added or removed between versions #967
howard-e
merged 16 commits into
development
from
supportPreservingResultsWithCommandsChanged
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded/removed between versions
…te all the requirements of copying results
# Conflicts: # server/resolvers/helpers/processCopiedReports.js
Paul-Clue
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did highlight one change, but it was something insignificant in a comment, so I removed the suggestion. The changes here are working fine, and the code seems good to me. Good stuff, as always.
…rocess (#974) * Unmarks test plan reports as being final if copied from older reports * Update tests with new logic; noticed results being lost when settings updated for a test * Delete server/migrations/20240320205951-regenerateHashes.js because it won't be needed depending on when this change goes to production * Fix propertiesToOmit
* Copies results into new TestPlanReports for a version when transitioning to DRAFT from CANDIDATE or RECOMMENDED if applicable * Copies results into new TestPlanReports for a version when transitioning to CANDIDATE from RECOMMENDED if applicable
…thCommandsChanged
This was referenced Apr 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
processCopiedReports.js
to account for when commands have been added/removed between versions.Previously, if a test had a command be included or removed in a subsequent update, all assertion results, unexpected behaviors and output would be discarded during the copy process.
Addresses the following from #935:
2, 3 and 4 have been individually reviewed in separate PRs through: