Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support results being copied even when commands have been added or removed between versions #967

Merged
merged 16 commits into from
Apr 10, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Mar 18, 2024

This PR updates processCopiedReports.js to account for when commands have been added/removed between versions.

Previously, if a test had a command be included or removed in a subsequent update, all assertion results, unexpected behaviors and output would be discarded during the copy process.

Addresses the following from #935:

  1. Need to account for when commands have been added, removed or edited for a test
  2. Unmark test plan reports as final once the results have been copied into a new TestPlanVersion's TestPlanReports to make it clearer that the results have been successfully copied. Test administrators will be able to make changes and mark as final again, if appropriate.
  3. Functionality to support copying results when a TestPlanVersion is in an advanced phase.
  4. Need to be able to pull older results when also adding an individual Test Plan Report to the Test Queue instead instead of just providing that functionality during the advance process from the Data Management page

2, 3 and 4 have been individually reviewed in separate PRs through:

@howard-e howard-e marked this pull request as ready for review March 25, 2024 14:26
Copy link
Collaborator

@Paul-Clue Paul-Clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did highlight one change, but it was something insignificant in a comment, so I removed the suggestion. The changes here are working fine, and the code seems good to me. Good stuff, as always.

howard-e added 3 commits April 1, 2024 13:51
…rocess (#974)

* Unmarks test plan reports as being final if copied from older reports

* Update tests with new logic; noticed results being lost when settings updated for a test

* Delete server/migrations/20240320205951-regenerateHashes.js because it won't be needed depending on when this change goes to production

* Fix propertiesToOmit
@howard-e howard-e changed the base branch from main to development April 4, 2024 22:26
* Copies results into new TestPlanReports for a version when transitioning to DRAFT from CANDIDATE or RECOMMENDED if applicable
* Copies results into new TestPlanReports for a version when transitioning to CANDIDATE from RECOMMENDED if applicable
@howard-e howard-e added the enhancement New feature or request label Apr 8, 2024
@howard-e howard-e merged commit 3a4d3c8 into development Apr 10, 2024
2 checks passed
@howard-e howard-e deleted the supportPreservingResultsWithCommandsChanged branch April 10, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants