-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macos interaction.pressKeys #37
Conversation
c27b6a2
to
070d931
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Years ago, in the context of the "harness" project, we agreed that unverifiable structured comments degrade the quality of a codebase. Seeing the same patterns being introduced here in this project, my preference is to extend the automated validation process, but I'd settle for documentation that describes how contributors can perform the validation manually. Barring either of those solutions, we should remove the comments.
37760de
to
a18dc51
Compare
@jugglinmike, I made these changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, @mzgoddard; I got sidetracked by a test failure which is also occurring on the main
branch. Now that I know this patch is unrelated, we can merge it and take on that problem separately.
(By the way, the code style also doesn't validate on main
--we really need to get CI set up!)
process.platform
lib/modules/types.js
lib/modules/win32
lib/modules/macos
lib/helpers/macos
with types and functions to parse key combination into an applescript and execute it with osascript