check each line of messages for the correct mode on mode switch #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglinmike
requested changes
Mar 28, 2024
src/agent/driver-test-runner.js
Outdated
Comment on lines
122
to
124
| // try to keep this short because it runs up to twice for every test | ||
| // have seen occasional timeout/misses at 500ms | ||
| const MODE_SWITCH_SPEECH_TIMEOUT = 750; |
There was a problem hiding this comment.
This is fine for a quick fix, but in general, a variable should be controlled from the context upon which it depends. What that means here is this value should be specified command-line argument. @ccanash Can you create a Task/Issue to track that change?
There was a problem hiding this comment.
src/agent/driver-test-runner.js
Outdated
Comment on lines
122
to
123
| // try to keep this short because it runs up to twice for every test | ||
| // have seen occasional timeout/misses at 500ms |
There was a problem hiding this comment.
This is a little vague (and colloquial besides). Have you observed delays longer than 500ms in the GitHub Actions environment? During local testing?
There was a problem hiding this comment.
Thanks. I've clarified those comments.
jugglinmike
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have seen errors while trying to switch modes on firefox. Occasionally it will end up reading out extra information after switching modes, for example
"Focus Mode\n Pizza Crust\n Grouping"Updated the mode switch to check each line of the output individually for the correct mode text.