Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types 2024 part 4 #56

Merged
merged 9 commits into from
May 29, 2024
Merged

Types 2024 part 4 #56

merged 9 commits into from
May 29, 2024

Conversation

jugglinmike
Copy link
Contributor

No description provided.

The TypeScript compiler requires that these methods conform to the API
signature even though they are considered "virtual" in a classical
object-oriented programming sense. Because the TypeScript compiler
considers returning nothing a violation ("A function whose declared type
is neither 'undefined', 'void', nor 'any' must return a value.") but is
satisfied by throwing an error, throw an error to indicate the virtual
status of these methods.
@jugglinmike jugglinmike requested a review from gnarf May 29, 2024 01:38
Copy link
Contributor

@gnarf gnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂

@jugglinmike
Copy link
Contributor Author

Thanks, Corey!

@jugglinmike jugglinmike merged commit 3daf7e0 into w3c:main May 29, 2024
4 checks passed
@jugglinmike jugglinmike deleted the types-2024-part-4 branch May 29, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants