-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continues correcting JSDoc types for Typescript tooling compatibility #58
Conversation
@jugglinmike there are two clusters of files remaining that would complete the typescript formalization work: I anticipate that fixing the types for both of these modules will be a bit difficult and probably require some amount of re-factoring. That being the case, I'm wondering if we might want to hold off on correcting these types for now, since a bigger refactor to simplify the harness is coming. In particular, I'm wondering if we might want to do away with the @jugglinmike @gnarf It might be a good idea for us to plan out that bigger refactor in a little more detail, so that we can make sure to only correct the types we know we'll continue using after the refactor? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jugglinmike @gnarf It might be a good idea for us to plan out that bigger refactor in a little more detail, so that we can make sure to only correct the types we know we'll continue using after the refactor?
Agreed. We prioritized this work because we'd have more confidence refactoring a well-typed project. There's no sense spending a lot of time fixing doomed files.
Got it. In that case, I'll go ahead and submit this PR and we'll determine later whether or not those last files will make it into the upcoming refactor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Chris!
No description provided.