Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usage documentation #60

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

jugglinmike
Copy link
Contributor

Update project description, remove information on the low-level "agent" utility (there are no known use-cases for direct invocation of this tool), remove CLI documentation (this is subject to rot), add instructions on installation and environment configuration, and add a usage example.

/cc @ChrisC

Update project description, remove information on the low-level "agent"
utility (there are no known use-cases for direct invocation of this
tool), remove CLI documentation (this is subject to rot), add
instructions on installation and environment configuration, and add a
usage example.
@jugglinmike jugglinmike requested a review from gnarf July 11, 2024 00:43
Copy link
Contributor

@gnarf gnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @ChrisC is some fresh 👀 here so curious if the updated readme leaves you with any questions we should answer

@ChrisC
Copy link
Contributor

ChrisC commented Jul 11, 2024

This all looks good to me @jugglinmike and reads pretty clearly imo.

I'm curious about the decision to leave out the CLI documentation. Are we also thinking of removing some of the additional flags as well to reduce possible CLI feature bloat? I get the sense that in actual usage of the tool, there may not be a whole lot of need for some of these flags?

@gnarf gnarf merged commit 21230f6 into w3c:main Jul 15, 2024
4 checks passed
@gnarf gnarf deleted the update-usage-documentation branch July 15, 2024 19:05
@jugglinmike
Copy link
Contributor Author

Thanks, Corey! Thanks, Chris!

I'm curious about the decision to leave out the CLI documentation. Are we also thinking of removing some of the additional flags as well to reduce possible CLI feature bloat? I get the sense that in actual usage of the tool, there may not be a whole lot of need for some of these flags?

To me, replicating the CLI documentation in the README is more a hazard for rot than a help for someone who is running the tool. I could be convinced otherwise, but I think the ideal solution would be to automate a check for parity between what the README says and what the CLI actually supports (for what it's worth, the two are currently out of sync on the main branch).

And yeah, I'm definitely in favor of removing features that we don't need (though we should also reach out to Vispero because it's not clear if/how they're using this code these days).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In production / Completed
Development

Successfully merging this pull request may close these issues.

3 participants