add placeholder support for new at additionalSettings #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglinmike
reviewed
Sep 24, 2024
| @@ -41,6 +41,7 @@ | |||
| * @property {string} commands[].keypresses[].keystroke single human-readable key or key chord press | |||
| * @property {string} [commands[].extraInstruction] human-readable additional instruction to follow | |||
| * @property {string} [commands[].settings] this property only exists on v2 tests | |||
| * @property {string[]} [commands[].additionalSettings] this property only exists on v2 tests | |||
There was a problem hiding this comment.
This change isn't present in Howard's patch. Since the file needs to match the corresponding file in the aria-at repository, we'll need to resolve the discrepancy before merging.
There was a problem hiding this comment.
yep, i noticed that too! i have a PR open to Howard's patch here: w3c/aria-at#1128
outofambit
force-pushed
the
support-additional-settings
branch
from
a555c2c to
46a6278
Compare
jugglinmike
requested changes
Nov 20, 2024
jugglinmike
approved these changes
Nov 20, 2024
|
I don't think we can merge this until w3c/aria-at#1125 lands, so I'll leave that part to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to support changes in w3c/aria-at#1125. See https://gist.github.com/howard-e/89a06d917946f5e922740dccee08d4e2 for more info.
All of the new "additional settings" that will be added are for JAWS and the harness + automation doesn't support JAWS, so this PR creates placeholders for where we would support potential settings on NVDA and VoiceOver when they are added in the future.