Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Action Menu Button Example Using aria-activedescendant Test Plan to V2 Test Format #1092

Merged
merged 22 commits into from
Aug 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4e79092
Convert test plan to v2 vormat
IsaDC Jul 21, 2024
5cf29be
Update example and remove previous directories
IsaDC Jul 22, 2024
1957682
add State 'collapsed' is conveyed assertion
IsaDC Jul 22, 2024
2834211
test remove assertion for state collapsed
IsaDC Jul 22, 2024
d13d644
Remove state collapsed assertion
IsaDC Jul 22, 2024
756713f
Add mode change and state collapsed assertions
IsaDC Jul 31, 2024
2ada72b
Add assertion exception for mode change to VoiceOver Commands
IsaDC Jul 31, 2024
bd2f171
Remove previous version files
IsaDC Jul 31, 2024
3a49768
Add switching to interaction mode assertion to test 1 for tab and shi…
IsaDC Aug 2, 2024
c4a7ccf
Clarify assertion for name of the menu button
IsaDC Aug 2, 2024
066efb3
Add refIds to assertions
IsaDC Aug 2, 2024
5cd023a
Editorial changes to assertion statements and phrases
mcking65 Aug 6, 2024
c156712
update references
mcking65 Aug 6, 2024
1651bb0
Assert that insert+tab in JAWS and NVDA and ctrl-opt-f3 give the name…
IsaDC Aug 7, 2024
ea3e94e
Add Virtual Cursor and Browse Mode to the Request information about a…
IsaDC Aug 7, 2024
b40a191
Reorder JAWS and NVDA commands
IsaDC Aug 7, 2024
ffbe3fe
Move after link to be just after menu button
mcking65 Aug 8, 2024
062a351
In tests 4,5, and 6, replace assertion 'nameActions' with new asserti…
mcking65 Aug 8, 2024
df50f6a
Set posinset and setsize assertions to priority 2, set roleMenu asser…
mcking65 Aug 8, 2024
3649433
Remove unnecessary priority overrid in tests.csv for assertion 'roleM…
mcking65 Aug 8, 2024
d5134a5
Revise order of assertions in each test for consistency
mcking65 Aug 8, 2024
91a1653
Add mode switching assertion to first two tests
mcking65 Aug 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/menu-button-actions-active-descendant/data/assertions.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
assertionId,priority,assertionStatement,assertionPhrase,refIds
nameActions,1,"Name of the menu button, 'Actions', is conveyed","convey name of the menu button, 'Actions'",button
nameMenuActions,3,"Name of the menu, 'Actions', is conveyed","convey name of the menu, 'Actions'",menu aria-labelledby
nameFocusedItemAction1,1,"Name of the focused item, 'Action 1', is conveyed","convey name of the focused item, 'Action 1'",aria-activedescendant
nameFocusedItemAction2,1,"Name of the focused item, 'Action 2', is conveyed","convey name of the focused item, 'Action 2'",aria-activedescendant
nameFocusedItemAction4,1,"Name of the focused item, 'Action 4', is conveyed","convey name of the focused item, 'Action 4'",aria-activedescendant
numberItemsMenu4,2,"Number of items in the menu,'(4', is conveyed","convey number of items in the menu, '4'",aria-setsize
roleFocusedItemMenuItem,2,"Role of the focused item, 'menu item', is conveyed","convey role of the focused item, 'menu item'",menuitem
roleMenu,3,Role 'menu' is conveyed,convey role 'menu',menu
roleMenuButton,1,Role 'menu button' is conveyed,convey role 'menu button',button aria-haspopup
stateCollapsed,1,State 'collapsed' is conveyed,convey state 'collapsed',aria-expanded
interactionModeEnabled,2,Screen reader switched from reading mode to interaction mode|{screenReader} switched from {readingMode} to {interactionMode},switch from reading mode to interaction mode|switch from {readingMode} to {interactionMode},
positionFocusedItemMenu1,2,"Position of the focused item in the menu, '1', is conveyed","convey position of the focused item in the menu, '1'",aria-posinset aria-activedescendant
positionFocusedItemMenu2,2,"Position of the focused item in the menu, '2', is conveyed","convey position of the focused item in the menu, '2'",aria-posinset aria-activedescendant
positionFocusedItemMenu4,2,"Position of the focused item in the menu, '4', is conveyed","convey position of the focused item in the menu, '4'",aria-posinset aria-activedescendant
42 changes: 0 additions & 42 deletions tests/menu-button-actions-active-descendant/data/commands.csv

This file was deleted.

32 changes: 32 additions & 0 deletions tests/menu-button-actions-active-descendant/data/jaws-commands.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
testId,command,settings,assertionExceptions,presentationNumber
navForwardsToMenuButton,b,virtualCursor,,1
navForwardsToMenuButton,f,virtualCursor,,1.1
navForwardsToMenuButton,tab,virtualCursor,2:interactionModeEnabled,1.2
navForwardsToMenuButton,down,virtualCursor,,1.3
navBackToMenuButton,shift+b,virtualCursor,,2
navBackToMenuButton,shift+f,virtualCursor,,2.1
navBackToMenuButton,shift+tab,virtualCursor,2:interactionModeEnabled,2.2
navBackToMenuButton,up,virtualCursor,,2.3
navForwardsToMenuButton,tab,pcCursor,,3
navBackToMenuButton,shift+tab,pcCursor,,4
reqInfoAboutMenuButton,ins+tab,virtualCursor,,7
reqInfoAboutMenuButton,ins+up,virtualCursor,,7.1
reqInfoAboutMenuButton,ins+tab,pcCursor,,8
reqInfoAboutMenuButton,ins+up,pcCursor,,8.1
openMenu,space,virtualCursor,2:interactionModeEnabled,10
openMenu,enter,virtualCursor,2:interactionModeEnabled,10.1
openMenu,space,pcCursor,,11
openMenu,enter,pcCursor,,11.1
openMenu,down,pcCursor,,11.2
openMenuToLastItem,up,pcCursor,,13
reqInfoAboutMenuItem,ins+tab,virtualCursor,,15
reqInfoAboutMenuItem,ins+up,virtualCursor,,15.1
reqInfoAboutMenuItem,ins+tab,pcCursor,,15.2
reqInfoAboutMenuItem,ins+up,pcCursor,,15.3
navToFirstItemMenu,home,pcCursor,,17
navToFirstItemMenu,down,pcCursor,,17.1
navToLastItemMenu,end,pcCursor,,19
navToLastItemMenu,up,pcCursor,,19.1
navToItemMenuByTypingCharacter,a,pcCursor,,21
activateMenuItem,enter,pcCursor,,23
closeMenu,esc,pcCursor,,25
32 changes: 32 additions & 0 deletions tests/menu-button-actions-active-descendant/data/nvda-commands.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
testId,command,settings,assertionExceptions,presentationNumber
navForwardsToMenuButton,b,browseMode,,1
navForwardsToMenuButton,f,browseMode,,1.1
navForwardsToMenuButton,tab,browseMode,2:interactionModeEnabled,1.2
navForwardsToMenuButton,down,browseMode,,1.3
navBackToMenuButton,shift+b,browseMode,,2
navBackToMenuButton,shift+f,browseMode,,2.1
navBackToMenuButton,shift+tab,browseMode,2:interactionModeEnabled,2.2
navBackToMenuButton,up,browseMode,,2.3
navForwardsToMenuButton,tab,focusMode,,3
navBackToMenuButton,shift+tab,focusMode,,4
reqInfoAboutMenuButton,ins+tab,browseMode,,7
reqInfoAboutMenuButton,ins+up,browseMode,,7.1
reqInfoAboutMenuButton,ins+tab,focusMode,,8
reqInfoAboutMenuButton,ins+up,focusMode,,8.1
openMenu,space,browseMode,2:interactionModeEnabled,10
openMenu,enter,browseMode,2:interactionModeEnabled,10.1
openMenu,space,focusMode,,11
openMenu,enter,focusMode,,11.1
openMenu,down,focusMode,,11.2
openMenuToLastItem,up,focusMode,,13
reqInfoAboutMenuItem,ins+tab,browseMode,,15
reqInfoAboutMenuItem,ins+up,browseMode,,15.1
reqInfoAboutMenuItem,ins+tab,focusMode,,15.2
reqInfoAboutMenuItem,ins+up,focusMode,,15.3
navToFirstItemMenu,home,focusMode,,17
navToFirstItemMenu,down,focusMode,,17.1
navToLastItemMenu,end,focusMode,,19
navToLastItemMenu,up,focusMode,,19.1
navToItemMenuByTypingCharacter,a,focusMode,,21
activateMenuItem,enter,focusMode,,23
closeMenu,esc,focusMode,,25
31 changes: 17 additions & 14 deletions tests/menu-button-actions-active-descendant/data/references.csv
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
refId,value
author,Isabel Del Castillo
authorEmail,isa.delcastillo5@gmail.com
title,Action Menu Button Example Using aria-activedescendant
reference,reference/2021-1-14_171136/menu-button-actions-active-descendant.html
designPattern,https://w3c.github.io/aria-practices/#menubutton
example,https://w3c.github.io/aria-practices/examples/menu-button/menu-button-actions-active-descendant.html
menu,https://w3c.github.io/aria/#menu
menuitem,https://w3c.github.io/aria/#menuitem
aria-haspopup,https://w3c.github.io/aria/#aria-haspopup
aria-controls,https://w3c.github.io/aria/#aria-controls
aria-activedescendant,https://w3c.github.io/aria/#aria-activedescendant
aria-labelledby,https://w3c.github.io/aria/#aria-labelledby
aria-expanded,https://w3c.github.io/aria/#aria-expanded
refId,type,value,linkText
author,metadata,Isabel Del Castillo,
authorEmail,metadata,isa.delcastillo5@gmail.com,
title,metadata,Action Menu Button Example Using aria-activedescendant,
reference,metadata,reference/2024-7-21_174946/menu-button-actions-active-descendant.html,Test Case Page for Action Menu Button Example Using aria-activedescendant
designPattern,metadata,https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/,APG Pattern: Menu Button
example,metadata,https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions-active-descendant/,APG Example: Actions Menu Button Using aria-activedescendant
menu,aria,menu,menu
menuitem,aria,menuitem,menuitem
aria-haspopup,aria,aria-haspopup,aria-haspopup
aria-controls,aria,aria-controls,aria-controls
aria-activedescendant,aria,aria-activedescendant,aria-activedescendant
aria-labelledby,aria,aria-labelledby,aria-labelledby
aria-expanded,aria,aria-expanded,aria-expanded
aria-posinset,aria,aria-posinset,aria-posinset
aria-setsize,aria,aria-setsize,aria-setsize
button,htmlAam,button,button
6 changes: 6 additions & 0 deletions tests/menu-button-actions-active-descendant/data/scripts.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
setupScript,setupScriptDescription
openMenuAndSetFocusToFirstItem,"opens the menu, and sets focus on 'Action 1'"
openMenuAndSetFocusToLastItem,"opens the menu, and sets focus on 'Action 4'"
setFocusAfterMenuButton,sets focus on a link after the menu button
setFocusBeforeMenuButton,sets focus on a link before the menu button
setFocusOnMenuButton,sets focus on the menu button
Loading
Loading