Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Carousel Example: Use button elements for slide controls and make rotation control always visible #1007

Closed
jongund opened this issue Mar 23, 2019 · 1 comment
Closed

Image Carousel Example: Use button elements for slide controls and make rotation control always visible #1007

jongund opened this issue Mar 23, 2019 · 1 comment
Assignees
@jongund
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Milestone
1.1 APG Release 4

Comments

@jongund
Copy link
Contributor

jongund commented Mar 23, 2019 •
edited by mcking65
Loading

Based on feedback in issue #971, revise the Feb 7, 2019 version of the Auto-Rotating Image Carousel Example
so the pause button is always visible and the slide controls are implemented with button elements.

Preview Link

The revised carousel can be seen in the issue1007-visible-pause-carousel branch.
@jongund jongund self-assigned this Mar 23, 2019
@jnurthen jnurthen added the bug Code defects; not for inaccurate prose label Apr 9, 2019
@sh0ji sh0ji added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy bug Code defects; not for inaccurate prose and removed bug Code defects; not for inaccurate prose labels Apr 9, 2019
@mcking65 mcking65 added this to the 1.1 APG Release 4 milestone Apr 23, 2019
@mcking65 mcking65 mentioned this issue Apr 23, 2019
Closed
1 task
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern and removed bug Code defects; not for inaccurate prose labels Apr 23, 2019
@mcking65 mcking65 changed the title add visible pause icon to auto-rotating carousel example Image Carousel Example: Use button elements for slide controls and make rotation control always visible Apr 23, 2019
@jongund jongund mentioned this issue Apr 23, 2019
Merged
mcking65 pushed a commit that referenced this issue Jul 11, 2019
@jongund @mcking65
Image Carousel Example: Use buttons for controls and make rotation co…
0ba3c1c 
…ntrol always visible (pull #1018)

Resolves issue #1007 by:
* making the stop/start rotation button always visible.
* Using button elements instead of links for the next and previous slide controls.

Also:
* Allows user to change between 2 view options: one with controls and captions overlayed on the images and one with them outside the image frames.
* Improves documentation in the accessibility features section.
* Adds regression tests.
@mcking65
Copy link
Contributor

mcking65 commented Jul 11, 2019 •
edited
Loading

Now resolved with commit 0ba3c1c. Thank you @jongund!!

The updated carousel can be viewed in the latest editor's draft here:
http://w3c.github.io/aria-practices/examples/carousel/carousel-1.html

michael-n-cooper pushed a commit that referenced this issue Jul 11, 2019
Generated by TRAVIS-CI 0ba3c1c
d1bc80f 
Image Carousel Example: Use buttons for controls and make rotation control always visible (pull #1018)

Resolves issue #1007 by:
* making the stop/start rotation button always visible.
* Using button elements instead of links for the next and previous slide controls.

Also:
* Allows user to change between 2 view options: one with controls and captions overlayed on the images and one with them outside the image frames.
* Improves documentation in the accessibility features section.
* Adds regression tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongund jongund

Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
Carousel Pattern and Examples Development Project
Status: Complete
Milestone
1.1 APG Release 4
Development

No branches or pull requests
5 participants
@jongund @jnurthen @mcking65 @sh0ji and others