Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update date picker dialog example to use single object and remove buttons from date grid #1360

Closed
jongund opened this issue Mar 30, 2020 · 0 comments · Fixed by #1362
Closed

Update date picker dialog example to use single object and remove buttons from date grid #1360

jongund opened this issue Mar 30, 2020 · 0 comments · Fixed by #1362

Comments

@jongund
Copy link
Contributor

jongund commented Mar 30, 2020

  • Improve code to use a single object
  • Remove buttons from the grid of dates
  • Make sure that aria-select only set on the current date
  • Check to make sure "space" updates the selected date and does not close dialog
@jongund jongund mentioned this issue Mar 31, 2020
Merged
6 tasks
@jongund jongund linked a pull request Mar 31, 2020 that will close this issue
Date Picker Dialog Example: Improve high contrast support and refactor javascript #1362
Merged
6 tasks
mcking65 added a commit that referenced this issue Jul 24, 2020
@jongund @zcorpan @mcking65
Date Picker Dialog Example: Improve high contrast support and refacto…
733ceab 
…r javascript (pull #1362)

Resolves #1360 with the following changes:
* Updates Javascript to use a single object.
* Fixes space key issues in grid.
* Improves high contrast support.

Co-authored-by: Simon Pieters <zcorpan@gmail.com>
Co-authored-by: Matt King <a11yThinker@Gmail.com>
michael-n-cooper pushed a commit that referenced this issue Jul 24, 2020
@zcorpan @mcking65
Generated by TRAVIS-CI 733ceab
cf79503 
Date Picker Dialog Example: Improve high contrast support and refactor javascript (pull #1362)

Resolves #1360 with the following changes:
* Updates Javascript to use a single object.
* Fixes space key issues in grid.
* Improves high contrast support.

Co-authored-by: Simon Pieters <zcorpan@gmail.com>
Co-authored-by: Matt King <a11yThinker@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Date Picker Dialog Example: Improve high contrast support and refactor javascript w3c/aria-practices
1 participant
@jongund