Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update multi-thumb slider design pattern #221

Closed
3 tasks done
mcking65 opened this issue Dec 13, 2016 · 4 comments
Closed
3 tasks done

Update multi-thumb slider design pattern #221

mcking65 opened this issue Dec 13, 2016 · 4 comments
Assignees
@annabbott
Labels
Pattern Page Related to a page documenting a Pattern
Milestone
1.1 APG Release 1

Comments

@mcking65
Copy link
Contributor

mcking65 commented Dec 13, 2016 •
edited
Loading

The multi-thumb slider design pattern
is largely complete. However, some open issues remain.

On December 13, 2016, I made revisions to improve consistency with the APG editorial guidelines, and noticed the following potential deficiencies in the pattern.

  • The description does not adequately describe the purpose of the widget. Consider adding an example use case.
  • Issues related to the relationships and dependencies between thumbs are not addressed. For example, dynamically adjusting the range of one thumb due to a change in the position of the other.

Final Review Requested October 22, 2017

All required changes and editorial cleanup are complete. The task force has previously discussed changes. Need only double-check of final editorial revisions.
@mcking65 mcking65 added this to the 1.1 PR milestone Dec 13, 2016
@mcking65 mcking65 added the question Issue asking a question label Dec 13, 2016
mcking65 added a commit that referenced this issue Dec 13, 2016
@mcking65
Editorial revisions of multi-thumb slider for issue #221
6642cb7 
modified aria-practices.html:
In the multi-thumb slider design pattern, made the following changes.
1. Added link at the beginning of the section to issue 221.
2. Rephrased introduction to simplify language and clarify meaning.
3. replaced keyboard interaction list with a link to the single thumb slider pattern.
4. Revised roles, states, and properties section to be consistent with APG editorial guidelines.
5. replaced links to external examples with link to issue 124.
@mcking65 mcking65 modified the milestones: Feb 2017 Heartbeat Draft, 1.1 PR Jan 7, 2017
@jnurthen jnurthen self-assigned this Jan 23, 2017
@mcking65
Copy link
Contributor Author

Per discussion in teleconference on Jan 23, 2017, removed suggestion to implement aria-controls. It is not clear how assistive technologies would be able to exploit aria-controls in order to enhance the accessibility of a multi-thumb slider.

@mcking65 mcking65 changed the title Review multi-thumb slider design pattern Update multi-thumb slider design pattern Jan 23, 2017
@mcking65 mcking65 added Pattern Page Related to a page documenting a Pattern and removed question Issue asking a question labels Jan 23, 2017
@mcking65 mcking65 modified the milestones: 1.1 Rec, Jan 2017 Clean Up May 15, 2017
@jnurthen
Copy link
Member

The description does not adequately describe the purpose of the widget. Consider adding an example use case.

Group thinks this is a good idea - perhaps a filter for max min required price.

Issues related to the relationships and dependencies between thumbs are not addressed. For example, dynamically adjusting the range of one thumb due to a change in the position of the other.

Yes this needs to be done.

@mcking65 mcking65 modified the milestones: 3Q17 Working Draft, 1.1 Rec Jul 24, 2017
mcking65 pushed a commit that referenced this issue Aug 28, 2017
@jongund @mcking65
Slider (Multi-Thumb) Pattern: Revise description and add example link…
90dca45 
… (pull #437)

For issue #221:

1. revised description to describe thumb dependencies.
2. Added link to example.
3. Removed link to example development issue.
4. Revise states and properties to describe when updates to maxvalue and minvalue are needed.
mcking65 added a commit that referenced this issue Oct 22, 2017
@mcking65
Multi-Thumb Slider Pattern: Editorial Cleanup
c8c2748 
For issue #221, made editorial revisions to the multi-thumb slider (id="slidertwothumb") design pattern in aria-practices.html.

1. Clarified wording of description.
2. Added link to single-thumb slider pattern in the description.
3. Changed format of example section to paragraph instead of list because there is only one example.
4. Changed target of link in keyboard interaction to go directly to the keyboard interaction section of single-thumb slider.
5. Removed a "must" from the roles, states, and properties.
@mcking65 mcking65 assigned annabbott and unassigned jongund and jnurthen Oct 22, 2017
@annabbott
Copy link

No issues detected.

@mcking65
Copy link
Contributor Author

Thank you @annabbott! Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annabbott annabbott

Labels
Pattern Page Related to a page documenting a Pattern
Projects
Slider pattern and example development project
Status: Complete
Milestone
1.1 APG Release 1
Development

No branches or pull requests
4 participants
@jongund @jnurthen @mcking65 @annabbott